Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: plugins #7064

Closed
wants to merge 7 commits into from
Closed

refactor: plugins #7064

wants to merge 7 commits into from

Conversation

pbkompasz
Copy link
Contributor

@pbkompasz pbkompasz commented Aug 31, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 029198b

Refactored several components and plugins to use the @vueuse/core library, the useShare hook, the defineNuxtPlugin function, and the truncateStr function. These changes simplify the code, reduce dependencies, improve performance, and fix bugs. Added support for Kusama and Polkadot network logos and names in the wallet component. Added a prop to control the visibility of the unlockable content button in the collection component.

🤖 Generated by Copilot at 029198b

Sing, O Muse, of the mighty refactorings
That the skilled developers wrought on the code
With defineNuxtPlugin and useClipboard they enhanced
The performance and functionality of the mode

@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 265837b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64f023f217515400089faf27
😎 Deploy Preview https://deploy-preview-7064--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 31, 2023

Code Climate has analyzed commit 265837b and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 31, 2023

AI-Generated Summary: This pull request includes several refactoring changes and improvements for the code. It focuses mainly on plugin refactoring, deletion of deprecated filters, and some replacements on the code.

The key changes include:

  1. Refactoring the 'icons' plugin: it's renamed from icons.ts to icons.client.ts with some simplification on how FontAwesomeIcon is utilized. The plugin is also removed from the Nuxt configuration file.

  2. Refactoring the 'vueTippy' plugin: similar strategy applied here, some Vue-specific code got improved to define it as a Nuxt plugin.

  3. Filters are deprecated: The file filters.ts was deleted entirely, with its associated filter functions (for instance, truncateStr) move into the Vue components directly.

  4. Refactoring the 'keyboardEvents' plugin: It was renamed from keyboardEvents.ts to keyboardEvents.client.ts and defined appropriately with Nuxt plugin format.

  5. Replacing 'vue-clipboard2' with useClipboard: It introduces a major change, where direct involvement of 'vue-clipboard2' has been eliminated and instead, a new utility function useClipboard used across several components.

By implementing these changes, the project gets structural improvements, enhances readability, and makes the code more maintainable in the long run.

@reviewpad reviewpad bot added the medium Pull request is medium label Aug 31, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 31, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo self-requested a review August 31, 2023 06:29
roiLeo
roiLeo reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to make this changes on nuxt branch?

@pbkompasz pbkompasz changed the base branch from main to nuxt August 31, 2023 09:05
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

❌ Deploy Preview for nuxt-kodadot failed.

Name Link
🔨 Latest commit 029198b
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/64f06001f54bfd0008f1589a

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pbkompasz pbkompasz changed the title Refactor plugins refactor: plugins Sep 1, 2023
@pbkompasz pbkompasz marked this pull request as ready for review September 1, 2023 07:42
@pbkompasz pbkompasz requested a review from a team as a code owner September 1, 2023 07:42
@pbkompasz pbkompasz requested review from daiagi and removed request for a team September 1, 2023 07:42
roiLeo
roiLeo suggested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not building & not working for me

@roiLeo roiLeo mentioned this pull request Sep 1, 2023
Closed
16 tasks
@pbkompasz
Copy link
Contributor Author

@roiLeo I have tested it while making the changes but not after merging it with the nuxt branch. I will look at it later today or tomorrow.

@roiLeo roiLeo mentioned this pull request Sep 1, 2023
Closed
20 tasks
@pbkompasz
Copy link
Contributor Author

@roiLeo I don't why it's not building but I cannot work on this now. I will have to close this and open a new one on Monday.

@pbkompasz pbkompasz closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo requested changes

@daiagi daiagi Awaiting requested review from daiagi daiagi was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbkompasz @roiLeo